Conversation
…n.extension_module
… place, somewhere (fix this in the future)
… they are python scripts?
…e name as the python library
|
The error comes from "CellConstructor". It's using the old cellconstructor code. |
… bay install_sources() instead
Maybe remove the setuptools later...
mesonepigreco
left a comment
mesonepigreco
left a comment
There was a problem hiding this comment.
The test are running on my local machine.
@diegomartinez2 could you try to fix the build workflow (build.yml) and the testsuite workflow to install cellconstructor from the github page, install meson, meson-python and ninja, and then build python-sscha with the pip install --no-build-isolation . command as explained in the comment? This should fix the error that cellconstructor 1.5 is not yet released and allow us to run the complete testsuite on github.
I would like to syncronize the release of the version 1.5 of cellconstructor and python-sscha.
There was a problem hiding this comment.
I would leave the requirement for python >=3.8 and <=3.12, otherwise it is a breaking change as python 3.12 is a breaking release.
There was a problem hiding this comment.
Anyway, we can fix the version control on cellconstructor by forcing a local environment installation of python. We first install cellconstructor from the github repository, which is the 1.5, then we force the python-sscha installation without creating the isolation build (that only looks at pypy for packages):
pip install --no-build-isolation .
For this to work, we must manually install meson before running the installation, otherwise pip will complain.
pip install meson meson-python ninja
There was a problem hiding this comment.
The installation of setuptools=64 must be removed, as this was related to the old build that required a very old version of setuptools.
So just ignore it.
There was a problem hiding this comment.
Note that this occurs multiple times throught this file
…cellconstructor from the "Install" part.
|
OK it passed all the checks now, but I removed the cellconstructor from requirements.txt so it may need to reintroduce it later. |
|
Now in github the cellconstructor is taken from the sources and compiled for the tests. |
mesonepigreco
left a comment
mesonepigreco
left a comment
There was a problem hiding this comment.
It seems everything is fine!
2 participants
Hi Lorenzo, I need somebody to test the meson install in other computers before adding it to master. I only tested in my laptop on a conda env, but it already has SSCHA in the base system so I have doubts. I think it will work on Apple ARM (M1/M2) architecture, but I do not have way to test it.
Meson_compiter_test